From 02d746717bd48adb27e82446d387773c01f2a393 Mon Sep 17 00:00:00 2001
From: Kroese <kroese@users.noreply.github.com>
Date: Fri, 21 Apr 2023 13:54:39 +0200
Subject: [PATCH 1/4] VM_NET_TAP

---
 run/network.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/run/network.sh b/run/network.sh
index 2d96c5c..42c6f74 100644
--- a/run/network.sh
+++ b/run/network.sh
@@ -3,6 +3,7 @@ set -eu
 
 # Docker environment variabeles
 
+: ${VM_NET_TAP='dsm'}
 : ${VM_NET_HOST:='VirtualDSM'}
 : ${VM_NET_MAC:='02:11:32:AA:BB:CC'}
 
@@ -29,7 +30,6 @@ configureDHCP() {
     echo "docker variable to your container: --device=/dev/vhost-net" && exit 85
   fi
 
-  VM_NET_TAP="dsm"
   echo "Info: Retrieving IP via DHCP using MAC ${VM_NET_MAC}..."
 
   ip l add link eth0 name "${VM_NET_TAP}" address "${VM_NET_MAC}" type macvtap mode bridge || true
@@ -84,7 +84,6 @@ configureDHCP() {
 configureNAT () {
 
   VM_NET_IP='20.20.20.21'
-  VM_NET_TAP="_VmNatTap"
 
   # Store IP for Docker healthcheck
   echo "${VM_NET_IP}" > "/var/dsm.ip"
@@ -168,6 +167,7 @@ if [ "$DEBUG" = "Y" ]; then
   echo "Info: Container IP is ${IP} with gateway ${GATEWAY}"
   ifconfig
   ip route
+
 fi
 
 if [ "$DHCP" != "Y" ]; then

From 0b4b33d8f28f8e93ed99f9984249aca983e9f51f Mon Sep 17 00:00:00 2001
From: Kroese <kroese@users.noreply.github.com>
Date: Fri, 21 Apr 2023 14:00:56 +0200
Subject: [PATCH 2/4] Shellcheck

---
 run/network.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/run/network.sh b/run/network.sh
index 42c6f74..c34f3fc 100644
--- a/run/network.sh
+++ b/run/network.sh
@@ -93,9 +93,9 @@ configureNAT () {
   ip addr add ${VM_NET_IP%.*}.1/24 broadcast ${VM_NET_IP%.*}.255 dev dockerbridge
   ip link set dockerbridge up
   #QEMU Works with taps, set tap to the bridge created
-  ip tuntap add dev ${VM_NET_TAP} mode tap
-  ip link set ${VM_NET_TAP} up promisc on
-  brctl addif dockerbridge ${VM_NET_TAP}
+  ip tuntap add dev "${VM_NET_TAP}" mode tap
+  ip link set "${VM_NET_TAP}" up promisc on
+  brctl addif dockerbridge "${VM_NET_TAP}"
 
   #Add internet connection to the VM
   iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE

From c3fb9912291dd986187544ffb72e12633048efb3 Mon Sep 17 00:00:00 2001
From: Kroese <kroese@users.noreply.github.com>
Date: Fri, 21 Apr 2023 14:06:32 +0200
Subject: [PATCH 3/4] TAP_NR

---
 run/network.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/run/network.sh b/run/network.sh
index c34f3fc..d868626 100644
--- a/run/network.sh
+++ b/run/network.sh
@@ -51,7 +51,8 @@ configureDHCP() {
 
   ip a flush "${VM_NET_TAP}"
 
-  TAP_PATH="/dev/tap$(</sys/class/net/${VM_NET_TAP}/ifindex)"
+  TAP_NR=$(</sys/class/net/"${VM_NET_TAP}"/ifindex)
+  TAP_PATH="/dev/tap${TAP_NR}"
 
   # Create dev file (there is no udev in container: need to be done manually)
   IFS=: read -r MAJOR MINOR < <(cat /sys/devices/virtual/net/"${VM_NET_TAP}"/tap*/dev)

From 13f2d79bc14df35babc834b15154738f7f426169 Mon Sep 17 00:00:00 2001
From: Kroese <kroese@users.noreply.github.com>
Date: Fri, 21 Apr 2023 14:07:50 +0200
Subject: [PATCH 4/4] VM_NET_TAP

---
 run/network.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/run/network.sh b/run/network.sh
index d868626..837950c 100644
--- a/run/network.sh
+++ b/run/network.sh
@@ -3,7 +3,7 @@ set -eu
 
 # Docker environment variabeles
 
-: ${VM_NET_TAP='dsm'}
+: ${VM_NET_TAP:='dsm'}
 : ${VM_NET_HOST:='VirtualDSM'}
 : ${VM_NET_MAC:='02:11:32:AA:BB:CC'}