From e70ed1900f5b9d155a5749e4662e6d94d6c36394 Mon Sep 17 00:00:00 2001
From: Kroese <kroese@users.noreply.github.com>
Date: Wed, 3 Jan 2024 14:02:16 +0100
Subject: [PATCH] fix: Port forwarding (#530)

---
 src/network.sh | 28 +++++++---------------------
 1 file changed, 7 insertions(+), 21 deletions(-)

diff --git a/src/network.sh b/src/network.sh
index 7544efa..3da2b9a 100644
--- a/src/network.sh
+++ b/src/network.sh
@@ -94,34 +94,20 @@ configureDNS() {
 getPorts() {
 
   local list=$1
-  local args=""
   local vnc="5900"
 
-  list="${list//,/ }"
-  list="${list## }"
-  list="${list%% }"
-
   if [[ "${DISPLAY,,}" == "vnc" ]] && [[ "$list" != *"$vnc"* ]]; then
-    if [ -z "$list" ]; then
-      list="$vnc"
-    else
-      list="$list $vnc"
-    fi
+    [ -z "$list" ] && list="$vnc" || list="$list,$vnc"
   fi
 
-  if [ -n "$list" ]; then
-    if [[ "$list" != *" "* ]]; then
-      args=" ! --dport $list"
-    else
-      args=" -m multiport ! --dports "
-      for port in $list; do
-        args="${args}${port},"
-      done
-      args="${args%?}"
-    fi
+  [ -z "$list" ] && return 0
+  
+  if [[ "$list" != *","* ]]; then
+    echo " ! --dport $list"
+  else
+    echo " -m multiport ! --dports $list"
   fi
 
-  echo "$args"
   return 0
 }